Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 🦋 to the CLI #62

Merged
merged 4 commits into from
Jun 1, 2019
Merged

Add 🦋 to the CLI #62

merged 4 commits into from
Jun 1, 2019

Conversation

emmatown
Copy link
Member

I thought it'd be cool if the CLI had some butterflies.
I'm not 100% sure about the emoji on the questions, maybe it should stay as the question mark? or 🦋 ? but then it's not aligned so ¯\_(ツ)_/¯
Also, maybe all the logged things should be split by \n and the emoji should be added before each line for the things that log multiple lines?
changeset cli with butterflies

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2019

🦋 Changeset is good to go

Latest commit: 1e29c1c

We got this.

Not sure what this means? Click here to learn what changesets are.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2019

🦋 Changeset is good to go

Latest commit: fdb1468

We got this.

Not sure what this means? Click here to learn what changesets are.

@Noviny
Copy link
Collaborator

Noviny commented Jun 1, 2019

Changeset bot is really getting out of hand.

@Noviny
Copy link
Collaborator

Noviny commented Jun 1, 2019

I'm not 100% sure about the emoji on the questions

My 'probably too cute' thought is to put 🐛next to questions, and 🦋next to other things.

I'm happy just with the replacement though. Thanks for this! This brings just that extra bit of joy to this project.

@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #62 into master will decrease coverage by 0.09%.
The diff coverage is 5.55%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #62     +/-   ##
========================================
- Coverage   82.69%   82.6%   -0.1%     
========================================
  Files          31      31             
  Lines         705     707      +2     
  Branches      118     119      +1     
========================================
+ Hits          583     584      +1     
- Misses        114     116      +2     
+ Partials        8       7      -1
Impacted Files Coverage Δ
packages/cli/src/utils/cli.ts 4.76% <0%> (ø)
packages/cli/src/utils/logger.ts 12.5% <12.5%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf76b98...1e29c1c. Read the comment docs.

@emmatown
Copy link
Member Author

emmatown commented Jun 1, 2019

My 'probably too cute' thought is to put 🐛next to questions, and 🦋next to other things.

I really like the cuteness of that, IMO the biggest problem with 🐛 is that 🐛 isn't the caterpillar emoji(though Apple happens to make it one), it's the bug emoji and bugs have a very different meaning in a software context which could confuse people.

Also, I've updated things so it prefixes multiline strings and everything is aligned so it looks like this:

changeset cli output

@Noviny
Copy link
Collaborator

Noviny commented Jun 1, 2019

Yeah, bug emoji might trick some people.

This looks good! Am I good to merge it?

@emmatown
Copy link
Member Author

emmatown commented Jun 1, 2019

Yep, good to merge.

@Noviny Noviny merged commit 6dc510f into master Jun 1, 2019
@emmatown emmatown deleted the mitchellhamilton/more-butterflies branch June 1, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants