-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 🦋 to the CLI #62
Add 🦋 to the CLI #62
Conversation
🦋 Changeset is good to goLatest commit: 1e29c1c We got this. Not sure what this means? Click here to learn what changesets are. |
🦋 Changeset is good to goLatest commit: fdb1468 We got this. Not sure what this means? Click here to learn what changesets are. |
Changeset bot is really getting out of hand. |
My 'probably too cute' thought is to put 🐛next to questions, and 🦋next to other things. I'm happy just with the replacement though. Thanks for this! This brings just that extra bit of joy to this project. |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
========================================
- Coverage 82.69% 82.6% -0.1%
========================================
Files 31 31
Lines 705 707 +2
Branches 118 119 +1
========================================
+ Hits 583 584 +1
- Misses 114 116 +2
+ Partials 8 7 -1
Continue to review full report at Codecov.
|
I really like the cuteness of that, IMO the biggest problem with 🐛 is that 🐛 isn't the caterpillar emoji(though Apple happens to make it one), it's the bug emoji and bugs have a very different meaning in a software context which could confuse people. Also, I've updated things so it prefixes multiline strings and everything is aligned so it looks like this: |
Yeah, bug emoji might trick some people. This looks good! Am I good to merge it? |
Yep, good to merge. |
I thought it'd be cool if the CLI had some butterflies.
I'm not 100% sure about the emoji on the questions, maybe it should stay as the question mark? or
🦋 ?
but then it's not aligned so ¯\_(ツ)_/¯Also, maybe all the logged things should be split by
\n
and the emoji should be added before each line for the things that log multiple lines?