Change how we ask questions #75
Conversation
🦋 Changeset is good to goLatest commit: 2a7939c We got this. Not sure what this means? Click here to learn what changesets are. |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 82.75% 83.18% +0.43%
==========================================
Files 31 31
Lines 800 809 +9
Branches 143 145 +2
==========================================
+ Hits 662 673 +11
+ Misses 130 125 -5
- Partials 8 11 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This looks Aces.
My two biggest questions are:
'Switching from inquirer to enquirer', - I'm going to do some testing based on being able to filter packages still for Very Long Lists.
Second was the slightly awkward 'we will patch these, yes or we re-ask this forever'. I think that:
Summary -> major -> minor -> confirm
solves that. Having thought out the summary text might also help selecting packages for the changeset. But I guess can also do the opposite so shrug
| while (!shouldTheRestOfThePkgsBeMinorBumped) { | ||
| logger.error("The rest of the selected packages must be patch bumped"); | ||
| shouldTheRestOfThePkgsBeMinorBumped = await cli.askConfirm( | ||
| bold(`Are you okay with these packages having a ${blue("patch")} bump?`) |
There was a problem hiding this comment.
Hmmm. I'm wondering if we want to not ask about patch here, as this can sort of be covered by 'is this your summary'
If we do that, we could move to summary -> all Packages -> major -> minor -> confirm - I'm not entirely sure the implications of that and might be something to come back to, not for this PR.
Otherwise you go major -> minor -> summary -> confirm, and while this is technically fine (without this question), it feels odd not to get asked about patches?
Maybe we just log it out the information:
The rest of the packages will be released as a patch:
#list
and move on to the summary question.
There was a problem hiding this comment.
I've gotten rid of the question and kept the logging of the packages.
| { | ||
| name: "unchanged packages", | ||
| choices: unchangedPackagesNames | ||
| } |
There was a problem hiding this comment.
💯 This is both infinitely more readable as code, and also way more practical as a thing.
| @@ -0,0 +1 @@ | |||
| Improve how the CLI asks questions | |||
There was a problem hiding this comment.
Can we expand this a little more into how it's changed? I'd almost add the gif, but also the gif is 7MB and I don't really want to carry that around with this repo.
There was a problem hiding this comment.
Updated the text and embedded to the gif from the GH user content url so it's not in the repo and unless GH dies, it'll be accessible.
| "@types/semver": "^6.0.0", | ||
| "@types/uuid": "^3.4.4", | ||
| "bolt": "^0.22.1", | ||
| "boxen": "^1.3.0", | ||
| "chalk": "^2.1.0", | ||
| "cli-table": "^0.3.1", | ||
| "detect-indent": "^6.0.0", | ||
| "enquirer": "^2.3.0", |
There was a problem hiding this comment.
this is why things are nicer. I've been wondering why all the changes.
Closes #52
Still WIP mainly because I haven't fixed the tests yet but thought I'd open this to get feedbackThe tests are fixed now.