Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of rows the package selection question takes up #82

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jun 6, 2019

changeset package question in atlaskit

I've also checked the small number of packages case and it only uses the rows necessary.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2019

🦋 Changeset is good to go

Latest commit: c1d00ad

We got this.

Not sure what this means? Click here to learn what changesets are.

@codecov-io
Copy link

Codecov Report

Merging #82 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #82      +/-   ##
=========================================
+ Coverage   83.18%   83.2%   +0.02%     
=========================================
  Files          31      31              
  Lines         809     810       +1     
  Branches      145     145              
=========================================
+ Hits          673     674       +1     
  Misses        125     125              
  Partials       11      11
Impacted Files Coverage Δ
packages/cli/src/utils/cli.ts 7.69% <100%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9100029...c1d00ad. Read the comment docs.

@Noviny Noviny merged commit 29ff34e into master Jun 6, 2019
@Noviny Noviny deleted the mitchellhamilton/limit-rows-in-pkg-question branch June 6, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants