Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): #833 #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): #833 #919

wants to merge 1 commit into from

Conversation

jjangga0214
Copy link

@jjangga0214 jjangga0214 commented Aug 17, 2022

Thanks for this awesome project!

Close #833

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 146d283

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 146d283:

Sandbox Source
Vanilla Configuration

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case covering for the fixed behavior?

@gao-sun
Copy link

gao-sun commented Oct 21, 2022

we need this. @Andarist is there anyway we can help with to push it forward?

@Andarist
Copy link
Member

I have a really busy time at work rn. I will be reviewing PRs here etc when I get some spare time after the current crunch. Other than that - you could write a test case for this as it's still missing here.

@geekact
Copy link

geekact commented Feb 28, 2023

Any message here in 2023? This PR is very useful for me.

@iamjaredwalters
Copy link

Anything we can help with to get this across the line?

@yykyy123123
Copy link

这个这么久了 还没更吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot ignore internal package
6 participants