Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework dependency ranges updates #975

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Oct 6, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

鈿狅笍 No Changeset found

Latest commit: 3ffdbe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 6, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ffdbe0:

Sandbox Source
Vanilla Configuration

Comment on lines +62 to +63
if (workspaceRange === "*" || workspaceRange?.includes("/")) {
return {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: recheck if this shouldn't do a different thing with onlyUpdatePeerDependentsWhenOutOfRange: false

# Conflicts:
#	packages/cli/src/commands/version/version.test.ts
@desfero
Copy link

desfero commented Feb 8, 2023

@Andarist great work, are there any blockers to push this one forward?
It Is causing us quite a pain with changeset in our monorepo setup as each update forces the major bump of the whole monorepo and we need to manually update generated package.jsons and CHANGELOG.mds.

@Andarist
Copy link
Member Author

Andarist commented Feb 8, 2023

@Andarist great work, are there any blockers to push this one forward?

Yes, the main blockers are:

  • my kids and family (aka the life and the available time :P)
  • lack of tests for the fixed cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants