Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radical data #37

Merged
merged 2 commits into from Feb 3, 2018
Merged

Radical data #37

merged 2 commits into from Feb 3, 2018

Conversation

chanind
Copy link
Owner

@chanind chanind commented Feb 3, 2018

This PR pulls in radical data from Make Me a Hanzi, so that users can color the radical in a character differently if they wish. Users can set this color by passing radicalColor when creating a HanziWriter instance. While updating the data, the character field was removed to reduce the size of the data files since it's redundant and is not being used anyway.

closes #11

screen shot 2018-02-03 at 7 36 35 pm

@fzzylogic
Copy link

Updated an old stackexchange post to reflect fantastic recent developments.

@chanind
Copy link
Owner Author

chanind commented Feb 3, 2018

Glad to hear it! Thanks for keeping that post up to date!

@chanind chanind merged commit 85093ad into master Feb 3, 2018
@enjalot
Copy link

enjalot commented Jan 18, 2022

This is really cool, but I couldn't figure out how the radStrokes were defined (I don't see the corresponding data in makemeahanzi?).
I found some characters that are missing and was thinking about how to contribute them, but it would be good to know how the data here was derived.

@chanind
Copy link
Owner Author

chanind commented Jan 18, 2022

They come from the dictionary.txt file in make me a hanzi. The script which imports them into hanzi writer is here: https://github.com/chanind/hanzi-writer-data/blob/master/stroke_data_parser.py

@chanind chanind deleted the radical-data branch January 18, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Show radical color
3 participants