Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using SVG matrix transforms to determine mouse points where possible #84

Merged
merged 2 commits into from Jul 20, 2018

Conversation

chanind
Copy link
Owner

@chanind chanind commented Jul 19, 2018

This PR implements mouse/touch tracking using SVG matrix transforms as suggested by @larhun in #83, with a fallback to the old method if not supported.

  • tested in Chrome
  • tested in Safari
  • tested in Firefox
  • tested in IE

closes #83

@codecov-io
Copy link

Codecov Report

Merging #84 into master will decrease coverage by 1.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   99.41%   98.38%   -1.03%     
==========================================
  Files          22       22              
  Lines         854      868      +14     
  Branches      135      138       +3     
==========================================
+ Hits          849      854       +5     
- Misses          5       14       +9
Impacted Files Coverage Δ
src/HanziWriter.js 92.25% <40%> (-5.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f510a...22f22e8. Read the comment docs.

@chanind chanind merged commit 1210e84 into master Jul 20, 2018
@chanind chanind deleted the svg-matrix-pt-transform branch July 20, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad mouse tracking in quiz
2 participants