Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pydantic v1 module in pydantic v2 package #10

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

evroon
Copy link
Contributor

@evroon evroon commented Nov 16, 2023

Adds support for using the pydantic.v1 module of pydantic v2 for backwards compatibility. This makes migrations of pydantic v1 to v2 more gradual and easier.

Needs #9 for CI to pass

Includes a bump to 1.2.0

@evroon evroon self-assigned this Nov 16, 2023
@evroon evroon force-pushed the support-pydantic-v1-module-in-pydantic-v2-package branch from 52d8c83 to 85481dc Compare November 16, 2023 11:47
@evroon evroon marked this pull request as ready for review November 16, 2023 11:49
@evroon evroon requested a review from jochemb November 16, 2023 11:55
src/heliclockter/__init__.py Outdated Show resolved Hide resolved
@evroon evroon force-pushed the support-pydantic-v1-module-in-pydantic-v2-package branch from 528dd4d to db5b759 Compare November 16, 2023 12:14
Copy link
Contributor

@p-nilsson p-nilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evroon
Copy link
Contributor Author

evroon commented Nov 16, 2023

thanks for the feedback!
@OpsBotPrime merge

@OpsBotPrime
Copy link
Contributor

Pull request approved for merge by @evroon, rebasing now.

@OpsBotPrime
Copy link
Contributor

Rebased as 78f99d5, waiting for CI …

@OpsBotPrime
Copy link
Contributor

CI job 🟡 started.

@OpsBotPrime OpsBotPrime force-pushed the support-pydantic-v1-module-in-pydantic-v2-package branch from db5b759 to 78f99d5 Compare November 16, 2023 12:20
@OpsBotPrime OpsBotPrime merged commit 78f99d5 into master Nov 16, 2023
1 check was pending
@DanielNoord DanielNoord deleted the support-pydantic-v1-module-in-pydantic-v2-package branch November 19, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants