Split BuildPending into BuildStarted. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the change: BuildPending Nothing -> BuildPending BuildStarted (Just "example.com") -> BuildStarted "example.com" ... and slightly change the comment wording to "CI job started."
alex-mckenna
approved these changes
Aug 1, 2022
Comment on lines
+240
to
+243
| (BuildStarted ciUrl) -> ciLink ciUrl "🟡" | ||
| (BuildFailed (Just ciUrl)) -> ciLink ciUrl "❌" | ||
| _ -> pure () | ||
| a ! href (toValue $ commitUrl info sha) $ toHtml $ prettySha sha |
There was a problem hiding this comment.
I think I would change this, having the link to CI only be shown as an icon makes it easier to miss. If I didn't realise I would probably first click the SHA and possibly miss the fact the icon is a completely different link.
There was a problem hiding this comment.
Fair enough. I'll include a "CI build" link besides the hash when it is available.
|
UI as of 82ecce5:
|
|
UI as of febcaa2: The PR description has been updated with this. ... and here's how it looks before the build link arrives:
|
|
@OpsBotPrime merge yourself please and thank you. |
|
Pull request approved for merge by @rudymatela, rebasing now. |
Approved-by: rudymatela Auto-deploy: false
|
Rebased as 12b01d1, waiting for CI … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for: #137.
Closes: #77.
This changes how the status is represented to something more explicit and descriptive:
This will make the change in #137 much nicer and simpler.
I checked and this does not affect the parsing of status files during an upgrade.
There are two other somewhat unrelated changes explained below.
Build status wording
... and slightly change the build status comment wording to "CI job started."
Rendering Status + Commit Hash on the web interface
... and change web rendering of CI jobs. Besides the link to the CI, we also now include a link to the commit in GitHub.
Before:
After:
The icons are clickable and so are the commit hashes:
#110| 🟡 e711b80 | CI build#109| ❌ 95a8b8f | CI buildEven though the heading already identifies the build status, this makes it so that the link to CI is somewhat consistent with GitHub UX:
Having "View in CI | e711b80" looked a bit weird now that the commit hash is present.Not applicable anymore.