Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include git fetch in rebase instructions #158

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Include git fetch in rebase instructions #158

merged 1 commit into from
Aug 19, 2022

Conversation

rudymatela
Copy link

Closes: #122

@rudymatela rudymatela self-assigned this Aug 16, 2022
@rudymatela rudymatela added enhancement New feature or request good first issue Good for newcomers documentation Documentation labels Aug 16, 2022
@rudymatela
Copy link
Author

This is another PR I will use as a "real test" for Hoff itself after I deploy #137.

@rudymatela rudymatela mentioned this pull request Aug 16, 2022
Closed
43 tasks
RileyApeldoorn
RileyApeldoorn reviewed Aug 16, 2022
View reviewed changes
Copy link

@RileyApeldoorn RileyApeldoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RileyApeldoorn RileyApeldoorn self-requested a review August 16, 2022 15:34
RileyApeldoorn
RileyApeldoorn approved these changes Aug 16, 2022
View reviewed changes
Copy link

@RileyApeldoorn RileyApeldoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button, I meant to approve :)

@rudymatela
Copy link
Author

Thanks for the review @RileyApeldoorn!

Great. I'll have this ready to merge after the deploy of #137.

@rudymatela
Copy link
Author

@OpsBotPrime merge on Friday

@OpsBotPrime
Copy link

Pull request approved for merge by @rudymatela, waiting for rebase behind 2 pull requests.

@OpsBotPrime
Copy link

Speculatively rebased as c38a192 behind #166 and #157, waiting for CI …

@OpsBotPrime OpsBotPrime mentioned this pull request Aug 19, 2022
Merged
@OpsBotPrime
Copy link

CI job started.

@OpsBotPrime
Copy link

Speculative build failed. I will automatically retry after getting build results for #157.

@OpsBotPrime
Copy link

The build failed: https://channable.semaphoreci.com/workflows/d1097518-2283-4e06-bded-473deecb69f2?pipeline_id=8ccc1fb8-6708-4105-895a-894200ebcf36
If this is the result of a flaky test, close and reopen the PR, then tag me again.
Otherwise, push a new commit and tag me again.

@rudymatela
Copy link
Author

@OpsBotPrime merge

@OpsBotPrime
Copy link

Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command merge on Friday.

@rudymatela
Copy link
Author

@OpsBotPrime merge on Friday

@OpsBotPrime
Copy link

Pull request approved for merge by @rudymatela, rebasing now.

@OpsBotPrime
Copy link

Rebased as 5fbdd7c, waiting for CI …

@OpsBotPrime
Copy link

CI job started.

@OpsBotPrime OpsBotPrime merged commit 5fbdd7c into master Aug 19, 2022
@OpsBotPrime OpsBotPrime deleted the improve-rebase-instructions branch August 19, 2022 09:20
@rudymatela
Copy link
Author

This is a merge train example. #160
(Never mind this comment. I am just gathering a list to analyse.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RileyApeldoorn RileyApeldoorn RileyApeldoorn approved these changes

Assignees

@rudymatela rudymatela

Labels
documentation Documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include git fetch in rebase instructions
3 participants
@rudymatela @OpsBotPrime @RileyApeldoorn