Freeze the package versions based on the ones from nixpkgs #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents Icepeak from being built using the wrong versions after a `cabal update`. We could disable Hackage completely but that would break non-Nix builds.
robbert-vdh
force-pushed
the
robbert-vdh/freeze-cabal-deps
branch
from
dfafbf1
to
9f77477
Compare
|
I changed the check to just use |
fatho
reviewed
Jun 28, 2023
.semaphore/semaphore.yml
Outdated
| @@ -43,6 +43,10 @@ blocks: | |||
| - echo "max-jobs = auto" >> ~/.config/nix/nix.conf | |||
|
|
|||
| jobs: | |||
| - name: "Check frozen versions" | |||
| commands: | |||
| - "cabal build --dry-run all" | |||
There was a problem hiding this comment.
Might need a nix develop - it failed on CI because it cannot find cabal
There was a problem hiding this comment.
You're right, I forgot there's no devenv there. Should be fixed now.
|
Thanks! @OpsBotPrime merge |
|
Pull request approved for merge by @robbert-vdh, rebasing now. |
This makes sure the package versions from nixpkgs and the versions specified in the freeze file are in sync.
Approved-by: robbert-vdh Auto-deploy: false
|
Rebased as 4173a02, waiting for CI … |
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
robbert-vdh/freeze-cabal-deps
branch
from
be71b32
to
4173a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the plain Cabal and the Nix builds from using different versions. This is especially important when using Nix, as Cabal may start using more up to date versions of the package from Hackage if the user has run
cabal updatebefore and a local package database exists. Cabal can also be forced to use only the global package registry in which case this problem also doesn't exist, but that requires either breaking non-Nix builds or wrapping thecabalcommand.I also added the freeze files to the Nix builds so we'll get alerted if nixpkgs gets updated without also updating the freeze file.