Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nixpkgs pin #118

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Update nixpkgs pin #118

merged 4 commits into from
Dec 5, 2023

Conversation

crtschin
Copy link
Member

PR makes the following changes:

  • Updates the nixpkgs pin,
    • Regenerated the .cabal.freeze file and bounds using cabal gen-bounds
    • Hashable was updated, changing the order when converted to a list. I added a sort operation on the affected tests.
    • Added fourmolu pre-filled with our preferred parameters.
  • Drive-by change to use aeson's capability to directly output ByteString instead of using Value as an intermediary.

robbert-vdh
robbert-vdh approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@robbert-vdh robbert-vdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@crtschin
Copy link
Member Author

crtschin commented Dec 5, 2023

@OpsBotPrime merge

@OpsBotPrime
Copy link
Contributor

Pull request approved for merge by @crtschin, rebasing now.

@OpsBotPrime
Merge #118: Update nixpkgs pin
521d1c9 
Approved-by: crtschin
Auto-deploy: false
@OpsBotPrime
Copy link
Contributor

Rebased as 521d1c9, waiting for CI …

@OpsBotPrime
Copy link
Contributor

CI job 🟡 started.

@OpsBotPrime OpsBotPrime merged commit 521d1c9 into master Dec 5, 2023
1 check was pending
@OpsBotPrime OpsBotPrime deleted the update-nixpkgs branch December 5, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbert-vdh robbert-vdh robbert-vdh approved these changes

Assignees

@crtschin crtschin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crtschin @OpsBotPrime @robbert-vdh