Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for comments in secrets files #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add support for comments in secrets files #139

wants to merge 4 commits into from
+198 −195

Commits on Feb 22, 2024

  1. Add regression test for secrets file with comments 

    This test currently fails because Vaultenv drops the second secret. I
need to fix that, but let's add the test first.
    @ruuda
    ruuda committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8498cfb View commit details
    Browse the repository at this point in the history

  2. Break out the golden tests individually 

    Then when one fails, it will print only the failing example, not the
list with all the results.
    @ruuda
    ruuda committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    da15edd View commit details
    Browse the repository at this point in the history

  3. Add more tests for the secrets file parser 

    I want to make sure that touching the parser doesn't break things.
    @ruuda
    ruuda committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8a51b4d View commit details
    Browse the repository at this point in the history

  4. Rewrite the secrets file parser 

    There is a place for true parsers, but the Megaparsec one here was
fragile. I wanted to add support for comment lines to it but it was not
so clear where, and the current parser had this pretty dangerous failure
mode of ignoring half the input. Instead of trying to deal with that,
for Vaultenv's secrets file format, it is so simple, just splitting on
lines and then splitting on = and # should be fine.
    @ruuda
    ruuda committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cc50924 View commit details
    Browse the repository at this point in the history