Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up styled-components-related legacy #1961

Closed
Tracked by #1800
sungik-choi opened this issue Jan 31, 2024 · 0 comments · Fixed by #1962
Closed
Tracked by #1800

Clean up styled-components-related legacy #1961

sungik-choi opened this issue Jan 31, 2024 · 0 comments · Fixed by #1962
Assignees
@sungik-choi
Labels
enhancement Issues or PR related to making existing features better

Comments

@sungik-choi
Copy link
Contributor

No description provided.

@sungik-choi sungik-choi mentioned this issue Jan 31, 2024
Closed
@sungik-choi sungik-choi self-assigned this Jan 31, 2024
@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Jan 31, 2024
@sungik-choi sungik-choi mentioned this issue Jan 31, 2024
Merged
6 tasks
sungik-choi added a commit that referenced this issue Feb 1, 2024
@sungik-choi
Clean up styled-components-related legacy (#1962)
fe5f125 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

Fixes #1961

## Summary
<!-- Please brief explanation of the changes made -->

Clean up styled-components-related legacy

## Details
<!-- Please elaborate description of the changes -->

styled-components 관련 레거시를 제거합니다!

- peer deps에서 styled-components 제거
- styled-components 관련 패키지/설정 제거
- **`src/foundation` 제거**
- **`BezierProvider` 제거**
- **`css` 를 사용하는 믹스인 제거**
  - `gap`, `ellipsis`
  - Input 관련 믹스인
- `interpolation` 타입 제거
- 위 변경에 맞춰 스토리북의 foundation 사용처 마이그레이션

몇 가지 누락된 개선 사항들을 적용합니다.

- `Spinner`, `Tooltip` 에 `AlphaBezierCompnentProps` 적용 (drop `as`)
- `.storybook` 디렉터리 하위 파일에도 eslint이 적용되도록 변경 및 위 변경사항 마이그레이션

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungik-choi sungik-choi

Labels
enhancement Issues or PR related to making existing features better
Projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up styled-components-related legacy sungik-choi/bezier-react
1 participant
@sungik-choi