-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove path alias of tsconfig and use tilde(~) specifier #1109
Remove path alias of tsconfig and use tilde(~) specifier #1109
Conversation
|
Chromatic Report🚀 Congratulations! Your build was successful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint 룰이 변경되어야 할 것 같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Rebase 필요 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1109 +/- ##
========================================
Coverage 77.61% 77.61%
========================================
Files 296 296
Lines 3815 3815
Branches 846 846
========================================
Hits 2961 2961
Misses 559 559
Partials 295 295
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
import type { | ||
BezierComponentProps, | ||
ChildrenProps, | ||
DisableProps, | ||
SizeProps, | ||
AdditionalStylableProps, | ||
} from '~/src/types/ComponentProps' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 컨텍스트와는 다른데 import 개행 스타일이 사람마다 달라서, 매번 불필요한 diff가 상당히 많이 생기네요.
eslint 룰이나 prettier를 빨리 적용해야할듯.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Prettier 도입 관련해서는 니즈가 계속 있었던 것 같은데, 혹시 관련 이슈가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 오늘 내일중으로 이슈 생성해놓을게요~ 이번주나 다음주내로 빠르게 작업해보려고합니다.
이 PR 적용 이후에 작업하려고해요
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ButtonGroup
확인했습니다
충돌 해결되면 제가 머지하겠습니다 @Dogdriip |
Self Checklist
CODEOWNERS
file.Related Issue
Summary
tsconfig
에서 정의하는 path alias(paths
)를 제거하고, 절대경로 import를 tilde(~
) specifier로 사용할 수 있도록 합니다.Details
변경사항
tsconfig
에서 각 경로에 대해 일일히 절대경로를 설정해 줍니다.bezier-react/packages/bezier-react/tsconfig.json
Lines 24 to 35 in eb803d1
~/*
경로를./*
로 인식하도록 합니다.import ... from 'Foundation'
→import ... from '~/src/foundation'
import ... from 'Utils/testUtils'
→import ... from '~/src/utils/testUtils'
설명
src
디렉토리 내에src/pages
,src/images
등 새로운 폴더가 생길 때마다tsconfig
에서 이를 매핑해주어야 하며, Jest 설정 등도 동일하게 변경해주어야 합니다. 이는 Use Parcel as bundler instead of Rollup #1097 (comment) 에서도 설명한 바 있습니다.bezier-react/packages/bezier-react/jest.config.js
Lines 14 to 28 in eb803d1
baseUrl
과paths
에 의존하는 절대경로 세팅을 인식하지 못합니다. Parcel의 경우가 대표적으로, 대안으로 tilde나 absolute(/
) specifier를 기본 지원합니다. #paths
설정을 사용하도록 하고 있습니다.Breaking change or not (Yes/No)
사용처에서는 없습니다.
References