-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common tsconfig
, eslintrc
into seperate packages
#1114
Merged
Dogdriip
merged 24 commits into
channel-io:next-v1
from
Dogdriip:refactor/shared-tsconfig
Mar 9, 2023
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a8927ef
feat(packages): add tsconfig package
Dogdriip 9151eed
refactor(tsconfig.script): move into packages/tsconfig
Dogdriip ddb1c88
feat(bezier-react): add tsconfig as deps
Dogdriip 7c3a831
refactor(bezier-react): move eslintrc, tsconfig.eslint into package
Dogdriip 5d5e77e
fix(bezier-react/eslintrc): resolve path, remove bezier-figma-plugin …
Dogdriip 93457e2
feat(bezier-figma-plugin): move eslintrc into package
Dogdriip 91ff270
feat(packages): add eslint-config-bezier
Dogdriip 300e72f
feat(packages/*): use eslint-config-bezier
Dogdriip 446689c
refactor(root): remove eslint config/plugin deps from root workspace
Dogdriip a6099c8
docs(readme): add tsconfig, eslint-config-bezier to table
Dogdriip d0620bd
refactor(eslint-config-bezier): remove eslint from deps
Dogdriip 74f4119
chore(bezier-figma-plugin): add tsconfig deps
Dogdriip 4bbf9b9
fix(eslint-config-bezier): devDeps to deps
Dogdriip 56714d2
feat(root): add root eslintrc
Dogdriip be2822b
chore(packages): move config packages to supports (@inhibitor1217)
Dogdriip dfd72f2
fix(.eslintrc): remove redundant nextjs settings
Dogdriip 997bcc9
feat(eslint-config-bezier): add eslintrc for config package itself
Dogdriip cead66a
Merge branch 'next-v1' into refactor/shared-tsconfig
Dogdriip e20dd81
fix(root): remove root .eslintrc
Dogdriip 25e9bfc
fix(bezier-react/.eslintrc): fix import/order override path (@inhibit…
Dogdriip 274e71b
chore(supports/eslint-config-bezier): remove eslintrc of itself
Dogdriip d25bf19
Merge branch 'next-v1' into refactor/shared-tsconfig
Dogdriip fc50c26
Revert "docs(readme): add tsconfig, eslint-config-bezier to table"
Dogdriip 88ae450
feat(.vscode): add workspace settings for eslint
Dogdriip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"eslint.workingDirectories": [{ "mode": "auto" }] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
module.exports = { | ||
root: true, | ||
extends: ['bezier'], | ||
parserOptions: { | ||
tsconfigRootDir: __dirname, | ||
project: './tsconfig.eslint.json', | ||
}, | ||
overrides: [ | ||
{ | ||
files: ['./**/*'], | ||
rules: { | ||
'no-restricted-imports': 'off', | ||
'no-restricted-globals': 'off', | ||
}, | ||
}, | ||
], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"extends": "tsconfig/eslint.json", | ||
"include": [ | ||
".*.js", | ||
"src/**/*", | ||
"*.js", | ||
"*.ts" | ||
], | ||
"exclude": [ | ||
"node_modules", | ||
"dist", | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"extends": "tsconfig/eslint.json", | ||
"include": [ | ||
".*.js", | ||
"src/**/*", | ||
"*.js", | ||
"*.ts" | ||
], | ||
"exclude": [ | ||
"node_modules", | ||
"build", | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
module.exports = { | ||
extends: [ | ||
'@channel.io/eslint-config', | ||
], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"name": "eslint-config-bezier", | ||
"main": "index.js", | ||
"dependencies": { | ||
"@channel.io/eslint-config": "^1.4.1", | ||
"@channel.io/eslint-plugin": "^1.2.3", | ||
"@typescript-eslint/eslint-plugin": "^4.33.0", | ||
"@typescript-eslint/parser": "^4.33.0", | ||
"babel-eslint": "^8.2.6", | ||
"eslint-config-airbnb-typescript": "^12.3.1", | ||
"eslint-import-resolver-typescript": "^2.7.1", | ||
"eslint-import-resolver-webpack": "^0.10.1", | ||
"eslint-plugin-babel": "^5.3.1", | ||
"eslint-plugin-import": "^2.27.5", | ||
"eslint-plugin-jest": "^22.21.0", | ||
"eslint-plugin-jsx-a11y": "^6.7.1", | ||
"eslint-plugin-react": "^7.32.2", | ||
"eslint-plugin-react-hooks": "^4.6.0", | ||
"typescript": "^4.9.4" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"$schema": "https://json.schemastore.org/tsconfig", | ||
"compilerOptions": { | ||
"types": ["@types/node"], | ||
"noEmit": true, | ||
"allowJs": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"name": "tsconfig" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
{ | ||
"$schema": "https://json.schemastore.org/tsconfig", | ||
"compilerOptions": { | ||
"resolveJsonModule": true, | ||
"esModuleInterop": true, | ||
"module": "CommonJS" | ||
"module": "commonjs" | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package 이름이
eslint-config-bezier
라서bezier
로 로드되는거죠?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 맞습니다!