fix: change the identifier of the bezier icon to a string literal instead of a symbol #1411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
CODEOWNERS
file.Related Issue
None
Summary
아이콘 컴포넌트의 식별자를 심볼에서 문자열 리터럴로 변경합니다.
Details
식별자가 심볼일 경우 아래와 같은 문제가 발생할 수 있습니다. (했습니다...)
bezier-react에 peer dependency로 bezier-icons를 추가하는 방식으로 문제를 해결할 수도 있습니다. 하지만 bezier-icons는 bezier-react와 꼭 쌍으로 사용해야하는 패키지가 아니고, bezier-react를 사용하는 사용처에서도 아이콘을 사용하지 않음에도 bezier-icons를 설치해야하는 불편함이 발생하게 됩니다. 또한 굳이 Symbol을 사용할 정도로 엄격하게 고유성 체크를 할 필요는 없다고 판단하여 이 PR의 해결 방식을 적용했습니다.
Breaking change or not (Yes/No)
No. (bezier-react에선 Breaking Change입니다)
References