fix(form-label/helper-text): fix merging of classname not working properly when inside a FormControl
#2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly when inside a FormControl
🦋 Changeset detectedLatest commit: 0c4b04a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2156 +/- ##
==========================================
- Coverage 86.63% 86.62% -0.01%
==========================================
Files 126 126
Lines 2656 2655 -1
Branches 791 786 -5
==========================================
- Hits 2301 2300 -1
Misses 326 326
Partials 29 29 ☔ View full report in Codecov by Sentry. |
yangwooseong
approved these changes
Apr 11, 2024
sungik-choi
pushed a commit
that referenced
this pull request
Apr 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-react@2.0.2 ### Patch Changes - Fixes an issue where injecting `className` into `FormLabel`, `FormHelperText` inside a `FormControl` does not apply styles correctly. ([#2156](#2156)) by @sungik-choi - Updated dependencies - @channel.io/bezier-tokens@0.2.1 ## @channel.io/bezier-tokens@0.2.1 ### Patch Changes - Add "color" prefix to alpha color tokens and fix misnaming of alpha font/typography tokens. ([#2152](#2152)) by @sungik-choi ## bezier-figma-plugin@0.5.2 ### Patch Changes - Updated dependencies - @channel.io/bezier-react@2.0.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yangwooseong
pushed a commit
to yangwooseong/bezier-react
that referenced
this pull request
Apr 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - Fixes an issue where injecting `className` into `FormLabel`, `FormHelperText` inside a `FormControl` does not apply styles correctly. ([channel-io#2156](channel-io#2156)) by @sungik-choi - Updated dependencies - @channel.io/bezier-tokens@0.2.1 - Add "color" prefix to alpha color tokens and fix misnaming of alpha font/typography tokens. ([channel-io#2152](channel-io#2152)) by @sungik-choi - Updated dependencies - @channel.io/bezier-react@2.0.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yangwooseong
pushed a commit
to yangwooseong/bezier-react
that referenced
this pull request
Apr 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. - Fixes an issue where injecting `className` into `FormLabel`, `FormHelperText` inside a `FormControl` does not apply styles correctly. ([channel-io#2156](channel-io#2156)) by @sungik-choi - Updated dependencies - @channel.io/bezier-tokens@0.2.1 - Add "color" prefix to alpha color tokens and fix misnaming of alpha font/typography tokens. ([channel-io#2152](channel-io#2152)) by @sungik-choi - Updated dependencies - @channel.io/bezier-react@2.0.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Summary
FormControl 내부에 위치한 FormLabel, FormHelperText(ErrorMessage)에 className 오버라이드가 잘 적용되지 않는 문제를 수정합니다.
Details
베지어 마이그레이션 과정에서 FormControl이 FormLabel, FormHelperText에게 래퍼 스타일을 전달하는 과정이 변경되었습니다.
변경 과정에서
get***Props함수가 반환하는className과 인자로 받는className의 속성명이 서로 겹치게 되었는데, 이 때 두 className이 모두 적용되는 게 아니라 인자로 받는className이 우선순위를 가지고 적용되면서 FormControl이 전달하는 래퍼 스타일이 무시되는 버그가 있었습니다. 이를 수정합니다.Breaking change? (Yes/No)
No
References