Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loadscript): add annotation & remove console error message #31

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

jeff-tbd
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
    • Android: Chrome, Samsung Internet
    • iOS: Safari, Chrome,

Related Issue

Summary

  • refactor(loadscript): add annotation & remove console error message

Details

  • If Channel SDK script is already loaded, this method does nothing.
  • remove console error for loading twice

Breaking change? (Yes/No)

  • No

References

…or loading twice

- If Channel SDK script is already loaded, this method does nothing. - remove console error for
loading twice
@jeff-tbd jeff-tbd self-assigned this Oct 10, 2023
@jeff-tbd jeff-tbd merged commit f784271 into channel-io:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant