Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances: support ESM and CommonJS #40

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

jeff-tbd
Copy link
Contributor

@jeff-tbd jeff-tbd commented Oct 27, 2023

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
    • Android: Chrome, Samsung Internet
    • iOS: Safari, Chrome,

Related Issue

Summary

  • Support ESM and CommonJS

Details

  • fix package.json
    • Remove unnecessary settings in the package.json files field entry (README)
    • Apply conditional exports

Breaking change? (Yes/No)

  • No

References

- README is always included regardless of settings
- package.json: main, modules
- for tree-shaking
@jeff-tbd jeff-tbd changed the title Enhances/support ejs v1.1.1 Enhances: support ES Module Oct 27, 2023
@jeff-tbd jeff-tbd self-assigned this Oct 27, 2023
@jeff-tbd jeff-tbd added the enhancement New feature or request label Oct 27, 2023
@jeff-tbd jeff-tbd changed the title Enhances: support ES Module Enhances: support ESM and CommonJS Oct 27, 2023
@jeff-tbd jeff-tbd merged commit f28af02 into channel-io:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant