Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(settings): remove unnecessary settings #47

Merged
merged 2 commits into from
Nov 24, 2023
Merged

refactor(settings): remove unnecessary settings #47

merged 2 commits into from
Nov 24, 2023

Conversation

jeff-tbd
Copy link
Contributor

@jeff-tbd jeff-tbd commented Nov 7, 2023 •
edited

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
    • Android: Chrome, Samsung Internet
    • iOS: Safari, Chrome,

Related Issue

Summary

  • remove unnecessary duplicated typescript config
  • version update
  • fix scope name

Details

  • remove unnecessary typescript config
    • declarationDir
    • forceConsistentCasingInFileNames
  • remove duplicated typescript config
    • include, outDir
  • .npmrc -> fix scope name(@channel-io -> @channel.io)

Breaking change? (Yes/No)

  • No

References

@jeff-tbd
refactor(settings): remove unnecessary settings
ebf12d7 
- tsconfig
  - declarationDir
  - forceConsistentCasingInFileNames
- .npmrc -> fix scope name(@channel-io -> @channel.io)
@jeff-tbd jeff-tbd self-assigned this Nov 7, 2023
@jeff-tbd jeff-tbd added change-version chore Changes to the build process or auxiliary tools and libraries such as documentation generation labels Nov 24, 2023
@jeff-tbd jeff-tbd merged commit 99c9c83 into channel-io:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeff-tbd jeff-tbd

Labels
change-version chore Changes to the build process or auxiliary tools and libraries such as documentation generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jeff-tbd