Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0 #29

Merged
merged 4 commits into from
Dec 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@channel.io/eslint-config",
"version": "1.2.0",
"version": "1.3.0",
"description": "eslint configuration for channel.io web",
"main": "index.js",
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions rules/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ module.exports = {
'import/no-extraneous-dependencies': 'off', // package.json directory hierarchy problem
'import/order': ['error', { groups: ['external', 'builtin', 'internal', 'parent', 'sibling', 'index'] }],
'import/prefer-default-export': 'off',
'import/no-named-defult': 'off',
'max-len': ['error', 130],
'new-cap': 'off',
'@channel.io/no-classnames-with-one-argument': 'error',
Expand Down
1 change: 1 addition & 0 deletions rules/react.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module.exports = {
'react-hooks/exhaustive-deps': 'error', // Checks effect dependencies
'react-hooks/rules-of-hooks': 'error', // Checks rules of Hooks
'react/jsx-key': 'warn', // TODO: (@axel) 사용처 버전업 진행 후 error 레벨로 변경. // Checks required key prop in JSX exist
'react/default-props-match-prop-types': 'off', // See: https://github.com/yannickcr/eslint-plugin-react/issues/2396
'react/destructuring-assignment': ['warn', 'always'],
'react/forbid-prop-types': 'off',
Expand Down
1 change: 1 addition & 0 deletions rules/typescript.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module.exports = {
'@typescript-eslint/no-unused-vars': ['error'],
'@typescript-eslint/consistent-type-imports': ['warn'],
'no-dupe-class-members': 'off', // Allow method overriding (will be checked by tsc)
'no-undef': 'off',
'no-unused-vars': 'off',
Expand Down