Use a lockfile to serialize blessclient invocations #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2018 16:52
ryanking
reviewed
Nov 20, 2018
| ) | ||
|
|
||
| // GetConfigPath gets the config path from a cobra cmd | ||
| func GetConfigPath(cmd *cobra.Command) (string, error) { |
There was a problem hiding this comment.
Probably fine for now but we should maybe consider using viper for this.
There was a problem hiding this comment.
yeah, i have another pr locally where i'm doing this
ryanking
suggested changes
Nov 20, 2018
added 3 commits
November 20, 2018 09:56
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 35.77% 41.02% +5.24%
==========================================
Files 10 12 +2
Lines 601 646 +45
==========================================
+ Hits 215 265 +50
+ Misses 358 350 -8
- Partials 28 31 +3
Continue to review full report at Codecov.
|
added 2 commits
November 20, 2018 13:33
ryanking
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrated with tools like terraform or ansible, multiple concurrent runs of blessclient resulted in unnecessary work. Instead, serialize blessclient commands.