New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
erratic undo/redo/reset behavior on "color by" toggling #1099
Comments
seve
changed the title
erratic undo/redo/reset behavior on color by toggling
erratic undo/redo/reset behavior on "color by" toggling
Jan 8, 2020
Small update: you can reproduce the first behavior described by @seve by a simpler set of actions. Try any action from cellxgene/client/src/reducers/undoableConfig.js Lines 168 to 171 in 124254d
|
mweiden
added a commit
that referenced
this issue
Jan 24, 2020
Fixes #1099 When the previous state that the undo feature is trying to roll back to has no filter state, merging javascript dictionaries result in keeping the current state filter, preventing the actionFilter from saving the new state.
mweiden
added a commit
that referenced
this issue
Jan 24, 2020
Fixes #1099 When the previous state that the undo feature is trying to roll back to has no filter state, merging javascript dictionaries result in keeping the current state filter, preventing the actionFilter from saving the new state.
mweiden
added a commit
that referenced
this issue
Jan 27, 2020
* Undo feature: fix case where previous state has no state filter Fixes #1099 When the previous state that the undo feature is trying to roll back to has no filter state, merging javascript dictionaries result in keeping the current state filter, preventing the actionFilter from saving the new state. * Fix whitespace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is an example of one instance where history is lost and it isn't possible to undo or redo:
Here is another example where undoing and redoing do not have an effect on the color state:
The text was updated successfully, but these errors were encountered: