Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erratic undo/redo/reset behavior on "color by" toggling #1099

Closed
seve opened this issue Jan 8, 2020 · 1 comment · Fixed by #1124 or #1165
Closed

erratic undo/redo/reset behavior on "color by" toggling #1099

seve opened this issue Jan 8, 2020 · 1 comment · Fixed by #1124 or #1165
Assignees
Labels
bug frontend front-end issue

Comments

@seve
Copy link
Member

seve commented Jan 8, 2020

Here is an example of one instance where history is lost and it isn't possible to undo or redo:
bug1

Here is another example where undoing and redoing do not have an effect on the color state:
bug2

@seve seve added bug frontend front-end issue labels Jan 8, 2020
@seve seve changed the title erratic undo/redo/reset behavior on color by toggling erratic undo/redo/reset behavior on "color by" toggling Jan 8, 2020
@bkmartinjr bkmartinjr self-assigned this Jan 8, 2020
@bkmartinjr bkmartinjr added this to the 0.15.0 milestone Jan 9, 2020
@mweiden
Copy link
Contributor

mweiden commented Jan 14, 2020

Small update: you can reproduce the first behavior described by @seve by a simpler set of actions. Try any action from debounceOnActions, hit undo, and then perform the same action. This behavior is caused by this logic:

if (
debounceOnActions.has(actionType) &&
shallowObjectEq(action, prevFilterState.prevAction)
) {

mweiden added a commit that referenced this issue Jan 24, 2020
Fixes #1099

When the previous state that the undo feature is trying to roll back to
has no filter state, merging javascript dictionaries result in keeping
the current state filter, preventing the actionFilter from saving the
new state.
mweiden added a commit that referenced this issue Jan 24, 2020
Fixes #1099

When the previous state that the undo feature is trying to roll back to
has no filter state, merging javascript dictionaries result in keeping
the current state filter, preventing the actionFilter from saving the
new state.
mweiden added a commit that referenced this issue Jan 27, 2020
* Undo feature: fix case where previous state has no state filter

Fixes #1099

When the previous state that the undo feature is trying to roll back to
has no filter state, merging javascript dictionaries result in keeping
the current state filter, preventing the actionFilter from saving the
new state.

* Fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend front-end issue
Projects
None yet
3 participants