You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current code does not allow user to select a (legal) ontology term if it contains various non-alphanumeric characters (eg, a comma, dash, etc). Anything in the ontology file should be legal (which means any unicode point). In addition, this will require validation that the CSV escaping is correctly handled when saving/loading.
Notes from discussion on desired approach:
1 - We still validate user input when they enter a label (i.e., not an ontology term), and still restrict to a subset of all characters.
2 - When they enter an ontology term, we use the exact term, even if it contains characters not in the set used to validate de novo terms in #1.
3 - To make these behaviors as similar as possible, we will add ( ) - to the allowed characters list in user-entered labels legal characters (see #1).
4 - CSV escaping will be properly implemented for load and save
End result:
any term in the ontology will be selectable, loadable and savable.
de novo terms entered by the user, not in the ontology, will be restricted to a sub-set of ASCII A-Za-z0-9_-()
Closing for now, with the caveat that long-term we're going to have to handle the inconsistency between user-created annotations vs ontology-provided terms re: commas, etc
Current code does not allow user to select a (legal) ontology term if it contains various non-alphanumeric characters (eg, a comma, dash, etc). Anything in the ontology file should be legal (which means any unicode point). In addition, this will require validation that the CSV escaping is correctly handled when saving/loading.
Notes from discussion on desired approach:
1 - We still validate user input when they enter a label (i.e., not an ontology term), and still restrict to a subset of all characters.
2 - When they enter an ontology term, we use the exact term, even if it contains characters not in the set used to validate de novo terms in #1.
3 - To make these behaviors as similar as possible, we will add ( ) - to the allowed characters list in user-entered labels legal characters (see #1).
4 - CSV escaping will be properly implemented for load and save
End result:
A-Za-z0-9_-()
@sidneymbell - please edit if I missed something.
The text was updated successfully, but these errors were encountered: