New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better error display for unsupported browsers #1477
Comments
MDN has a thoughtful article on feature detection vs user agent detection: https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent If we decide to go the user agent route, |
Todo: add hard page refresh to trigger Google Analytics, so that we know how many people are seeing the page (and by proxy, to be explicit, what percentage of our users are on an unsupported browser) |
As of now, what browsers are confirmed unsupported? |
Candidates likely to be outside of design scope or not work:
Suggest starting with the known failures we have, eg, the old IE that doesn't have required feature suppot. |
Sentry issue: HOSTED-CELLXGENE-N |
Sentry issue: HOSTED-CELLXGENE-1R |
Sentry issue: HOSTED-CELLXGENE-1E |
Sentry issue: HOSTED-CELLXGENE-1B |
Sentry issue: HOSTED-CELLXGENE-18 |
Sentry issue: HOSTED-CELLXGENE-M |
For context, Meta uses The gist is that older browsers don't recognize The actual PR is here: https://github.com/chanzuckerberg/khepri/pull/3825! |
Sentry issue: HOSTED-CELLXGENE-1Q |
|
It seems like we just want to have a better error message for browsers we don't support, instead of showing a blank page or something? If so, I think #1477 (comment) would solve the problem, and for the versions of modern browsers we support, we could do the same as Meta?:
Then we just need to make sure to transpile our code down to ES6 and things should just work! |
We don't support small form factor devices. So we want to catch that as well. My primary requirement is that we show a clean page, with a friendly "sorry" message, if it is a device we don't support. |
Ahh viewport size! I see that iPad's viewport size is 1024x768. So do we just add another requirement that the viewport needs to be above that (and explicitly say that in the message too)? And we will also show the sorry message if someone resizes their laptop browser to be below the threshold too? |
Sentry issue: HOSTED-CELLXGENE-1X |
Sentry issue: HOSTED-CELLXGENE-26 |
Sentry issue: HOSTED-CELLXGENE-22 |
Looks like the
|
@tihuan Looks like Meta's supported browser list includes Edge versions 15-18 which don't support |
Ooh awesome catch, @seve ! 🥇 🎉 I was looking at https://stackoverflow.com/a/36949791, it seems like https://github.com/anonyco/FastestSmallestTextEncoderDecoder is the library recommended by MDN! |
Sentry issue: HOSTED-CELLXGENE-2K |
Sentry issue: HOSTED-CELLXGENE-27 |
Sentry issue: HOSTED-CELLXGENE-W |
Sentry issue: HOSTED-CELLXGENE-2P |
Sentry issue: HOSTED-CELLXGENE-1G |
We see occasional users attempt to use cellxgene with unsupported browsers (eg, IE on Win 7). It would be nice if the front-end could present the user with something other than a hard failure.
The text was updated successfully, but these errors were encountered: