Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a new dataset for testing automation #1578

Open
3 tasks
seve opened this issue Jun 17, 2020 · 4 comments
Open
3 tasks

Design a new dataset for testing automation #1578

seve opened this issue Jun 17, 2020 · 4 comments
Labels
P3 Priority 3

Comments

@seve
Copy link
Member

seve commented Jun 17, 2020

We would benefit from adding/replacing our current testing dataset(pbmc3k) with a deeper and more diverse dataset. This could be enhanced with a joining of multiple existing datasets that would stress our typing system as well. Would require a refactoring of our hard-coded values and snapshots.

Ideally this dataset would eliminate the need to bring non-annotation related tests into the e2eAnnotations.test.js testing file.

Rough to-do list:

  • Define dataset requirements/design
  • Create dataset
  • Fix broken tests due to hard-coded values/snapshots

Some cases that need to be covered by the updated dataset:

Feel free to comment more ideas and I'll add to the list!

@bkmartinjr bkmartinjr added this to the Milestone 2: Auth[NZ] milestone Jul 17, 2020
@brianraymor brianraymor removed this from the Milestone 2: Auth[NZ] milestone Aug 7, 2020
@signechambers1
Copy link
Contributor

@seve @maniarathi is this still relevant? do you want to include as some part of https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell/44?

@maniarathi
Copy link
Contributor

Good call! I added it to our smoketest epic!

@signechambers1
Copy link
Contributor

@maniarathi the smoke test epic is closed, ok to close this ticket?

@maniarathi
Copy link
Contributor

Beefing up our set of valid-but-unusual datasets is still a thing we need to work on to be honest and we had to trim our efforts in testing due to time constraints. I'd like to keep this open because the ideas listed above are good, but I'm not sure when to get to it. I'd mark it as a P3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority 3
Projects
None yet
Development

No branches or pull requests

5 participants