Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label selection on trunctated category lists #1646

Merged
merged 2 commits into from
Jul 18, 2020

Conversation

bkmartinjr
Copy link
Contributor

Fixes #1556

Category label select/deselect was not working correctly on any category with a truncated list of labels (ie, where we display a subset of labels). This resolves the issue.

@bkmartinjr bkmartinjr added this to the Milestone 1: Schema milestone Jul 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2020

Codecov Report

Merging #1646 into main will increase coverage by 5.82%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   62.18%   68.01%   +5.82%     
==========================================
  Files          36      115      +79     
  Lines        3721    10058    +6337     
  Branches        0      458     +458     
==========================================
+ Hits         2314     6841    +4527     
- Misses       1407     3157    +1750     
- Partials        0       60      +60     
Flag Coverage Δ
#frontend 71.43% <60.00%> (-28.57%) ⬇️
#javascript 71.43% <60.00%> (-28.57%) ⬇️
#smokeTest ?
#smokeTestAnnotations ?
#unitTest 71.43% <60.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/util/stateManager/controlsHelpers.js 42.22% <60.00%> (ø)
server/data_common/rwlock.py 88.23% <0.00%> (ø)
server/common/app_config.py 73.24% <0.00%> (ø)
client/src/util/clip.js 77.77% <0.00%> (ø)
client/src/util/dataframe/dataframe.js 92.50% <0.00%> (ø)
server/data_anndata/anndata_adaptor.py 79.80% <0.00%> (ø)
server/data_common/fbs/NetEncoding/Column.py 77.77% <0.00%> (ø)
client/src/annoMatrix/crossfilter.js 97.97% <0.00%> (ø)
client/src/util/quantile.js 100.00% <0.00%> (ø)
...er/data_common/fbs/NetEncoding/JSONEncodedArray.py 53.33% <0.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6412b5...0da0fb2. Read the comment docs.

@bkmartinjr bkmartinjr merged commit 410566f into main Jul 18, 2020
@bkmartinjr bkmartinjr deleted the bkmartinjr/1556-truncated-cat-seln branch July 18, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell selection via a category with truncated list of labels isn't working properly
3 participants