Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main embedding pan does not have 1:1 drag with cursor #722

Closed
bkmartinjr opened this issue Apr 21, 2019 · 3 comments · Fixed by #768 or #893
Closed

main embedding pan does not have 1:1 drag with cursor #722

bkmartinjr opened this issue Apr 21, 2019 · 3 comments · Fixed by #768 or #893
Assignees
@bkmartinjr
Labels
bug frontend front-end issue
Milestone
0.12.0

Comments

@bkmartinjr
Copy link
Contributor

in pan/zoom mode, if you drag the main embedding, it will not move 1:1 with the cursor. Underlying view move is scaled differently (slightly less on my machine).

found by @colinmegill

image.png
@bkmartinjr bkmartinjr added bug frontend front-end issue labels Apr 21, 2019
@bkmartinjr bkmartinjr self-assigned this May 17, 2019
@bkmartinjr
Copy link
Contributor Author

@colinmegill - FYI, this is caused a configuration setting in our camera code (I'm in there fixing other issues and found it). Currently it is set to move at 40% of mouse speed (eg, if the mouse moves 100 pixels, the canvas will translate 40 pixels).

This is a UX decision. Per this bug report, I'll change it to a 1:1 pan. If this is too jumpy, we can change it back. For reference, it is controlled by the panSpeed constant in util/camera.js

Change will be in an upcoming PR.

@bkmartinjr bkmartinjr added this to the 0.10.0 milestone May 17, 2019
bkmartinjr pushed a commit that referenced this issue May 17, 2019
change pan speed to 1 per issue #722
b9c77e5
@bkmartinjr bkmartinjr mentioned this issue May 17, 2019
Merged
bkmartinjr pushed a commit that referenced this issue May 20, 2019
coordinate system fixes for embedded graph (#768)
fcc05f6 
* change pan speed to 1 per issue #722

* correct handle scaling of graph when aspect ratio less than one

* add package lock

* add invert to our scale functions

* correctly transform to/from gl coordinates

* remove unused import

* fix naming of import

* update smoke tests
@bkmartinjr bkmartinjr mentioned this issue May 23, 2019
Closed
@liaprins-czi liaprins-czi reopened this Aug 5, 2019
@liaprins-czi
Copy link

This issue is still happening in master: Visualization does not match/keep up with speed of mouse.

@bkmartinjr
Copy link
Contributor Author

Thanks @liaprins-czi - I'll dig into it.

@bkmartinjr bkmartinjr modified the milestones: 0.10.0, 0.12.0 Aug 8, 2019
@bkmartinjr bkmartinjr mentioned this issue Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkmartinjr bkmartinjr

Labels
bug frontend front-end issue
Projects
None yet
Milestone
0.12.0
2 participants
@bkmartinjr @liaprins-czi