Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify histogram thresholds in fixed-length array #1086

Merged
merged 2 commits into from Jan 6, 2020

Conversation

mweiden
Copy link
Contributor

@mweiden mweiden commented Jan 2, 2020

@mweiden mweiden self-assigned this Jan 2, 2020
Copy link

@liaprins-czi liaprins-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still getting the same issues (uneven bin widths + extra-wide far-right bin) after I use the clip tool:

Screen Shot 2020-01-02 at 4 32 01 PM

@mweiden
Copy link
Contributor Author

mweiden commented Jan 3, 2020

@liaprins-czi are you sure that you have the branch version installed correctly? This is what I see:

Screen Shot 2020-01-02 at 4 38 01 PM

Copy link

@liaprins-czi liaprins-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for me now! (I must have had mweiden-fix-issue-1042 earlier checked out instead of 1082).

Copy link
Contributor

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Matt!

@mweiden mweiden changed the base branch from mweiden-fix-issue-1042 to master January 6, 2020 18:46
@mweiden mweiden merged commit 4c1ecf9 into master Jan 6, 2020
@mweiden mweiden deleted the mweiden-fix-issue-1082 branch January 6, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram bars are often different widths and each histogram has a different number of bars
4 participants