Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do in-app compression only for CLI #1285

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

bkmartinjr
Copy link
Contributor

In-app compression of HTTP responses is now enabled only for the CLI, which uses the flask dev HTTP server. When being launched as a WSGI server, no compression is done on the assumption that it will be handled by the httpd.

Also deleted old dead code related to an unused HTTP response caching module.

@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #1285 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   62.41%   62.39%   -0.03%     
==========================================
  Files          66       66              
  Lines        4920     4922       +2     
  Branches      374      374              
==========================================
  Hits         3071     3071              
- Misses       1757     1759       +2     
  Partials       92       92              
Flag Coverage Δ
#backend 52.06% <0.00%> (-0.04%) ⬇️
#frontend 75.00% <ø> (ø)
#javascript 75.00% <ø> (ø)
#python 52.06% <0.00%> (-0.04%) ⬇️
#smokeTest 100.00% <ø> (ø)
#smokeTestAnnotations 100.00% <ø> (ø)
#unitTest 62.39% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
server/app/app.py 0.00% <ø> (ø)
server/cli/launch.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785bf5b...9db63bd. Read the comment docs.

Copy link
Contributor

@bmccandless bmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr merged commit d196cbc into master Mar 24, 2020
@bkmartinjr bkmartinjr deleted the bkmartinjr/split-server-classes branch March 24, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants