Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffexp limit UI and configuration #1336

Merged
merged 11 commits into from
Apr 9, 2020

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Apr 2, 2020

Expose the differential expression cell count limit via UI, and make it configurable on the backend.

Fixes #1328

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #1336 into master will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   62.42%   62.45%   +0.02%     
==========================================
  Files          67       67              
  Lines        5198     5202       +4     
  Branches      377      377              
==========================================
+ Hits         3245     3249       +4     
  Misses       1861     1861              
  Partials       92       92              
Flag Coverage Δ
#backend 52.73% <87.50%> (+0.06%) ⬆️
#frontend 75.26% <ø> (ø)
#javascript 75.26% <ø> (ø)
#python 52.73% <87.50%> (+0.06%) ⬆️
#smokeTestAnnotations 100.00% <ø> (ø)
#unitTest 62.45% <87.50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
server/common/default_config.py 100.00% <ø> (ø)
server/common/app_config.py 66.46% <87.50%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d457988...d158334. Read the comment docs.

@bkmartinjr bkmartinjr changed the title [WIP] diffexp limit UI and configuration diffexp limit UI and configuration Apr 8, 2020
@bkmartinjr
Copy link
Contributor Author

I have reviewed the front-end elements, which are courtesy of @colinmegill (thank you!)

@bkmartinjr bkmartinjr added this to the hosted pilot cleanup milestone Apr 9, 2020
Copy link
Contributor

@bmccandless bmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr merged commit e2a12ba into master Apr 9, 2020
@bkmartinjr bkmartinjr deleted the bkmartinjr/1328-diffexp-limit-warning branch April 9, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front-end informs user of diffexp cell limits, does not fail ungracefully when they are hit
4 participants