New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance and correctness fixes to brushable histogram #1390

Merged

bkmartinjr merged 1 commit into master from bkmartinjr/1326-slow-continuous

Apr 14, 2020

Contributor

bkmartinjr commented Apr 13, 2020

This PR fixes two issues:

rendering performance of continuous histograms was very slow due to poor state management in the component. This caused excessive re-rendering of every histogram when any histogram state changed.
there was a edge case where the highest value in a continuous range was not selectable

Fixes #1326
Fixes #1389


          performance and correctness fixes to brushable histogram

20e3d0b

bkmartinjr requested a review from colinmegill

April 13, 2020 23:14

colinmegill approved these changes

View reviewed changes

client/src/components/brushableHistogram/index.js

    
                  continuousSelectionRange: state.continuousSelection[myName],

                  colorAccessor: state.colors.colorAccessor

                  isColorAccessor: state.colors.colorAccessor === field,

Contributor

colinmegill Apr 14, 2020

Nice!

bkmartinjr merged commit a3df1a9 into master

bkmartinjr deleted the bkmartinjr/1326-slow-continuous branch

April 14, 2020 03:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment