-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux refactor #1571
Redux refactor #1571
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 65.69% 68.12% +2.42%
==========================================
Files 104 115 +11
Lines 9352 10023 +671
Branches 378 458 +80
==========================================
+ Hits 6144 6828 +684
- Misses 3126 3135 +9
+ Partials 82 60 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome PR, Bruce! Only partial reviews from a quick glance 😄 Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incremental review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit + a couple questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small fix then we're ready to go!
This is a major refactor of the internal reducer state/store. An "annotated matrix" object, which is a lazy data loader/proxy for the server-side is introduced. Components now have responsibility for loading any data they depend upon, and computing any derived state from that data. This is facilitated by the use of
react-async
.Fixes #1605
To do list: