-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin #2525
Conversation
Solid! Can we also remove Also you might need to change the title of the PR to match conventional commits |
Codecov Report
@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
- Coverage 71.64% 71.61% -0.03%
==========================================
Files 94 94
Lines 6464 6496 +32
Branches 738 770 +32
==========================================
+ Hits 4631 4652 +21
- Misses 1757 1768 +11
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I fixed the PR title. |
@tihuan Do these snapshot changes make sense to you? |
Thanks for pinging! Huh, the inline style is completely gone in the snapshot. Does the app look good running locally? UPDATE: Oh wait, my bad! It's just Github's weird syntax highlighting 😆 It looks like most of the snapshot diffs are adding If the app looks fine running locally, then LGTM! |
Related to issue #2495
Reviewers
@seve @Bento007
Changes
Replaced occurrence of optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin and updated dependencies.