Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover-over highlighting to the scatterplot #900

Merged
merged 2 commits into from Aug 27, 2019

Conversation

bkmartinjr
Copy link
Contributor

The main embedding viz has hover-over hightlighting for categorical metadata. This PR does the same for the expression scatterplot.

Fixes #892

this PR also includes a small performance improvement to the graph component update loop. It was unnecessarily recreating a JS function each time through the loop. This is replaced by a single function created a component construction time.

@bkmartinjr bkmartinjr merged commit b309367 into master Aug 27, 2019
@bkmartinjr bkmartinjr deleted the bkmartinjr/highlight-scatterplot branch August 27, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scatterplot does not show categorical highlighting state
2 participants