Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all non-major dependencies #1588

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

czi-developer-foundations
Copy link
Collaborator

@czi-developer-foundations czi-developer-foundations commented Apr 10, 2023

This PR contains the following updates:

Package Type Change
@chanzuckerberg/axe-storybook-testing devDependencies ^6.3.0 -> ^6.3.1
@chanzuckerberg/eslint-config-edu-ts (source) devDependencies ^1.0.7 -> ^1.0.9
@chanzuckerberg/eslint-plugin-stories (source) devDependencies ^3.2.12 -> ^3.2.14
@chanzuckerberg/story-utils (source) devDependencies ^3.0.12 -> ^3.0.14
@commitlint/cli (source) devDependencies ^17.5.1 -> ^17.6.1
@commitlint/config-conventional (source) devDependencies ^17.4.4 -> ^17.6.1
@headlessui/react dependencies ^1.7.13 -> ^1.7.14
@types/react (source) devDependencies ^18.0.31 -> ^18.0.35
chromatic (source) devDependencies ^6.17.2 -> ^6.17.3
eslint (source) devDependencies ^8.37.0 -> ^8.38.0
eslint-plugin-testing-library devDependencies ^5.10.2 -> ^5.10.3
lint-staged devDependencies ^13.2.0 -> ^13.2.1
stylelint (source) devDependencies ^15.3.0 -> ^15.4.0
ts-jest (source) devDependencies ^29.0.5 -> ^29.1.0

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@github-actions
Copy link

github-actions bot commented Apr 10, 2023

size-limit report 📦

Path Size
components 118.9 KB (0%)
styles 3.13 KB (0%)

@booc0mtaco
Copy link
Contributor

@ahuth @jinlee93 do you know how to re-start this? I think we can pick up story-utils at 4.0, but ... i guess this wouldn't prompt to do that update?

@ahuth
Copy link
Contributor

ahuth commented Apr 12, 2023

I think this is configured to do only non-major version updates, so it won't pick up v4. May have to do that manually.

v4 is for Storybook 7, though. So I think 3.0.13 is what you want (that's the fixed version for Storybook 6).

@jinlee93
Copy link
Contributor

Yup, renovate is configured for non major bumps. Think we should upgrade to sb7 and story-utils to v4 separately as renovate will continue to failing prs

@booc0mtaco
Copy link
Contributor

booc0mtaco commented Apr 17, 2023

@jinlee93 @ahuth looks like we are picking up story-utils .14, and there's a remaining flaky test with modal (which is likely one of the tests I unskipped). I think we are good to go on this bump now. Thanks!

EDIT: the patch bump to headlessUI seems to be breaking existing snapshots :(

@booc0mtaco
Copy link
Contributor

Updating the snapshots related to this fix: tailwindlabs/headlessui#2347

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1588 (c715047) into next (9a67e16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1588   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         279      279           
  Lines        4292     4292           
  Branches      784      784           
=======================================
  Hits         3937     3937           
  Misses        353      353           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@booc0mtaco thanks for the snap updates

@booc0mtaco booc0mtaco merged commit f0ec287 into next Apr 17, 2023
@booc0mtaco booc0mtaco deleted the renovate/all-minor-patch branch April 17, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants