Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Link)!: remove and reset deprecated props #1871

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat(Link)!: remove and reset deprecated props #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/Link/Link.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,11 +525,3 @@ button:where(.link--link) {
padding: 0 var(--eds-size-2);
}

/**
* Full-width link style
* A block link that fills 100% of the width of its container
* @deprecated ?
*/
.link--full-width {
width: 100%;
}
7 changes: 0 additions & 7 deletions src/components/Link/Link.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default {
children: 'Link',
variant: 'link',
status: 'brand',
fullWidth: false,
size: 'lg',
href: 'https://go.czi.team/eds',
// stop link from navigating to another page so we can click the link for testing
Expand All @@ -38,12 +37,6 @@ export default {
disable: true,
},
},
fullWidth: {
control: 'boolean',
table: {
disable: true,
},
},
onClick: {
table: {
disable: true,
Expand Down
11 changes: 0 additions & 11 deletions src/components/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,9 @@ export type LinkProps = LinkHTMLElementProps & {
* The link contents or label.
*/
children: ReactNode;
/**
* Toggles link that fills the full width of its container
* @deprecated
*/
fullWidth?: boolean;
'data-testid'?: string;
/**
* Link size inherits from the surrounding text.
*
* **Deprecated**. This will be removed in the next major version.
* @deprecated
*/
size?: Extract<Size, 'sm' | 'md' | 'lg'>;
} & VariantStatus;
Expand All @@ -48,7 +40,6 @@ export const Link = forwardRef<HTMLAnchorElement, LinkProps>(
variant = 'link',
status = 'brand',
size = 'lg',
fullWidth,
...rest
},
ref,
Expand All @@ -73,8 +64,6 @@ export const Link = forwardRef<HTMLAnchorElement, LinkProps>(
status === 'success' && styles['link--success'],
status === 'warning' && styles['link--warning'],
status === 'error' && styles['link--error'],
// Other options
fullWidth && styles['link--full-width'],
className,
);

Expand Down
Loading