-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Feature to detect terraform file version changes #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echanakira
changed the title
[WIP] Added all local files to fogg
[WIP] Feature to detect terraform file version changes
Jul 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 79.83% 79.09% -0.75%
==========================================
Files 21 25 +4
Lines 1840 1894 +54
==========================================
+ Hits 1469 1498 +29
- Misses 237 254 +17
- Partials 134 142 +8
Continue to review full report at Codecov.
|
echanakira
changed the title
[WIP] Feature to detect terraform file version changes
[feature] Feature to detect terraform file version changes
Aug 8, 2019
ryanking
suggested changes
Aug 8, 2019
ryanking
approved these changes
Aug 9, 2019
palasha
pushed a commit
to palasha/fogg
that referenced
this pull request
Apr 7, 2020
…rberg#329) * [BREAKING] Added all local files to fogg * Update local_parser_test.go * Local parser tests passing * Updated tests to be current * local_parser now retrieves all local modules and their versions * Can now retrieve local and global github modules * Refacted code to be more modular and use better variable names * Started writing out command functionality * TEMPORARY FIXES * Created testdata folder, with tests passing * Created working tests that utilize testdata * Examine temporarily * broken but duplicates removed * Added dependencies to vendors * Missing vendors added * Fixed test and added new folder to testdata * Added more comments * removed getSubmodules, added terraform/config * Implemented github client to get release tags * made createGitUrl more concise * Cleaned up latest.go style * Fixed go.mods * Got new github module * Testing removing go-github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a command that will search the terraform files of a Fogg project to see if they are using the latest module versions. Currently: The command, given a path, will successfully traverse the project to gather all of the terraform modules that are being used. Using that information, it loads the latest version of each module from GitHub or the terraform registry. Comparisons have not yet been implemented
The main files are located in
./cmd/exp/examine
and./exp/examine
Test Plan
Unit tests and testdata were created to make sure that functionality is working; however, the tests are not extensive.
References