update for v0.7.x downloader plugin interface #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming v0.7.x branch of miniwdl has a breaking change to the downloader plugin interface, sorry about this. It just adds two arguments to the entry point to give it access to the effective configuration and the task/workflow logger.
The first commit adds these two arguments and leaves everything else alone.
The second, optional commit gets the s3parcp docker image from the miniwdl configuration loader (which would source it either from the environment variable MINIWDL__S3PARCP__DOCKER_IMAGE or a configuration file [s3parcp] docker_image=...). Also it suggests filling that in at runtime using a WDL input instead of the f-string template. This is more a matter of preference clearly, either way works.