Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set docker service names #303

Closed
mlin opened this issue Nov 24, 2019 · 0 comments
Closed

set docker service names #303

mlin opened this issue Nov 24, 2019 · 0 comments
Labels
bug Something isn't working scalability
Projects

Comments

@mlin
Copy link
Collaborator

mlin commented Nov 24, 2019

docker auto-generates service names from word lists with about 25,500 possible combinations: https://github.com/moby/moby/blob/master/pkg/namesgenerator/names-generator.go

Consequently, error-inducing collisions are expected in any set of merely a few hundred services (d=25500, p=0.5).

This has happened to me at least twice during service creation, e.g.

2019-11-24 22:33:38,950 wdl.w:TestBulkRnaPR.w:call-target.t:call-rsem_quant-1 ERROR task rsem_quant (bulk_rna_pipeline.wdl Ln 287 Col 5) failed :: error: "APIError", message: "500 Server Error: Internal Server Error (\"rpc error: code = Unknown desc = name conflicts with an existing object\")"

We need to override the service names to something with more uniqueness/entropy.

(Container names are generated with a retry loop to avoid this problem, but service names are not. https://github.com/moby/moby/blob/e511b3be894465d81c21cab35b4f292d9250a4ca/daemon/names.go#L84 https://github.com/moby/moby/blob/8840071c26093d0589edb659b329e82892e496c2/daemon/cluster/convert/service.go#L143)

@mlin mlin added bug Something isn't working scalability labels Nov 24, 2019
@mlin mlin added this to Backlog in miniwdl via automation Nov 24, 2019
@mlin mlin moved this from Backlog to Next in miniwdl Dec 4, 2019
@mlin mlin moved this from Next to In progress in miniwdl Dec 4, 2019
mlin added a commit that referenced this issue Dec 4, 2019
@mlin mlin moved this from In progress to Pending release in miniwdl Dec 5, 2019
@mlin mlin closed this as completed Dec 6, 2019
miniwdl automation moved this from Pending release to Done Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scalability
Projects
miniwdl
  
Done
Development

No branches or pull requests

1 participant