Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdLib overhaul #123

Merged
merged 2 commits into from
Apr 28, 2019
Merged

StdLib overhaul #123

merged 2 commits into from
Apr 28, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Apr 23, 2019

Refactor StdLib (#14) in anticipation of needing to provide context-dependent typechecking/implementation logic for various functions. For example, numerous functions are tightly intertwined with the task execution environment and in some cases don't even make sense elsewhere (e.g. stdout()).

@coveralls
Copy link

coveralls commented Apr 23, 2019

Pull Request Test Coverage Report for Build 570

  • 148 of 155 (95.48%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Expr.py 47 48 97.92%
WDL/StdLib.py 82 88 93.18%
Files with Coverage Reduction New Missed Lines %
WDL/Expr.py 1 98.04%
WDL/_parser.py 3 94.84%
Totals Coverage Status
Change from base Build 565: 0.2%
Covered Lines: 2919
Relevant Lines: 3025

💛 - Coveralls

@mlin
Copy link
Collaborator Author

mlin commented Apr 24, 2019

@mlin mlin merged commit f2ed7a3 into master Apr 28, 2019
@mlin mlin deleted the mlin-stdlib-refactor branch June 18, 2019 06:23
@mlin mlin restored the mlin-stdlib-refactor branch June 18, 2019 06:23
@mlin mlin deleted the mlin-stdlib-refactor branch June 18, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants