-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add biowdl/tasks test corpus #157
Conversation
mlin
commented
Jun 13, 2019
•
edited
Loading
edited
- typechecker: workflow output expressions can reference previous workflow outputs (Variables in the output section can not be referenced in the output section. #155)
- parser: task 'non-input' declarations can interleave anywhere among other sections (task "pre-output" declarations #156)
- parser: spike in newline at end of input (accommodates last-line comments)
- check: make UnusedDeclaration's heuristic index files exception case-insensitive
- parser: spike in newline at end of input, to accommodate last-line comments - UnusedDeclaration: make heuiristic index files test case-insensitive - file issue for preoutput declarations
In the miniwdl test suite, we embed several public WDL corpi and ensure we parse them successfully and reproduce lint results. Here I've added biowdl/tasks to start with, taking care of a few miscellaneous compatibility issues (including #155). The main remaining thorn (which I imagine you've observed already) is the use of |
Pull Request Test Coverage Report for Build 650
💛 - Coveralls |
@mlin I don't think that task has ever been used. It seems like an artifact from the draft-2 days when we were still experimenting with WDL's capabilities and how to set things up. Unless @rhpvorderman has any objections (:stuck_out_tongue:), I will be removing it. |
@DavyCats that will be a big relief for us, thanks! Right now the test harness "blacklists" common.wdl and the files that import it, so that the tests don't run and fail on them. Later we'll bump the submodule revision, remove the blacklist, and chase down any remaining issues. |
@mlin |