Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biowdl/tasks test corpus #157

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Add biowdl/tasks test corpus #157

merged 4 commits into from
Jun 14, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Jun 13, 2019

mlin added 3 commits June 12, 2019 21:31
- parser: spike in newline at end of input, to accommodate last-line comments
- UnusedDeclaration: make heuiristic index files test case-insensitive
- file issue for preoutput declarations
@mlin
Copy link
Collaborator Author

mlin commented Jun 13, 2019

@rhpvorderman @DavyCats

In the miniwdl test suite, we embed several public WDL corpi and ensure we parse them successfully and reproduce lint results. Here I've added biowdl/tasks to start with, taking care of a few miscellaneous compatibility issues (including #155).

The main remaining thorn (which I imagine you've observed already) is the use of Object in common.ObjectMd5. Since the miniwdl project started when there was already general consensus to 'violently deprecate' (i.e. delete) Object from the WDL spec, we've been hoping to get away without implementing it at all. So, I wonder if there's any negotiability in the use of Object on your end? 😅

@coveralls
Copy link

coveralls commented Jun 13, 2019

Pull Request Test Coverage Report for Build 650

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 96.104%

Totals Coverage Status
Change from base Build 643: 0.006%
Covered Lines: 3231
Relevant Lines: 3362

💛 - Coveralls

@DavyCats
Copy link
Contributor

@mlin I don't think that task has ever been used. It seems like an artifact from the draft-2 days when we were still experimenting with WDL's capabilities and how to set things up. Unless @rhpvorderman has any objections (:stuck_out_tongue:), I will be removing it.

@mlin
Copy link
Collaborator Author

mlin commented Jun 14, 2019

@DavyCats that will be a big relief for us, thanks! Right now the test harness "blacklists" common.wdl and the files that import it, so that the tests don't run and fail on them. Later we'll bump the submodule revision, remove the blacklist, and chase down any remaining issues.

@mlin mlin merged commit 6b47fb2 into master Jun 14, 2019
@mlin mlin deleted the mlin-biowdl-corpi branch June 14, 2019 16:17
@rhpvorderman
Copy link
Contributor

@mlin
@DavyCats removed object from tasks and I just merged that into the latest develop branch of https://github.com/biowdl/tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants