Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring errors #161

Merged
merged 1 commit into from
Jun 17, 2019
Merged

refactoring errors #161

merged 1 commit into from
Jun 17, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Jun 16, 2019

  • OutOfBounds and EmptyArray inherit EvalError instead of ValidationError
  • Expr.eval() reraises any error as EvalError
  • introduce IntdeterminateType : ValidationError

@mlin
refactoring errors
ea3244f 
- OutOfBounds and EmptyArray inherit EvalError instead of ValidationError
- Expr.eval() reraises any error as EvalError
- introduce IntdeterminateType : ValidationError
@coveralls
Copy link

Pull Request Test Coverage Report for Build 668

  • 30 of 37 (81.08%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 96.272%
Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Error.py 7 8 87.5%
WDL/Expr.py 21 22 95.45%
WDL/Tree.py 1 2 50.0%
WDL/StdLib.py 1 5 20.0%
Totals Coverage Status
Change from base Build 666: 0.007%
Covered Lines: 3280
Relevant Lines: 3407
💛 - Coveralls

@mlin mlin merged commit d374e7f into master Jun 17, 2019
@mlin mlin deleted the mlin-error-cleanup branch June 18, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlin @coveralls