Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicate Gather operations in workflow dependencies #189

Merged
merged 3 commits into from
Jul 7, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Jul 7, 2019

When a value or call output inside a workflow scatter or conditional section is referenced by some identifier expression outside of that section, there's an implied operation to gather the array of values/outputs (or conditional value). We add a little Gather AST node which may sit in WDL.Expr.Ident.referee to represent this operation abstractly, which will be useful in scheduling workflow execution.

@coveralls
Copy link

coveralls commented Jul 7, 2019

Pull Request Test Coverage Report for Build 807

  • 49 of 50 (98.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Lint.py 10 11 90.91%
Totals Coverage Status
Change from base Build 799: 0.02%
Covered Lines: 3600
Relevant Lines: 3712

💛 - Coveralls

@mlin mlin merged commit 9b132ba into master Jul 7, 2019
@mlin mlin deleted the mlin-gather-referee branch July 15, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants