Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task runner: use runtime.memory to avoid oversubscribing host memory #268

Merged
merged 5 commits into from
Nov 10, 2019

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 10, 2019

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1246

  • 56 of 56 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.988%

Totals Coverage Status
Change from base Build 1243: 0.02%
Covered Lines: 4476
Relevant Lines: 4615

💛 - Coveralls

@mlin
Copy link
Collaborator Author

mlin commented Nov 10, 2019

Might be inconvenient to have this always on, as a large value will cause serialization of test jobs on smaller machines. Maybe user control the upper-limit values for cpu and memory (defaulting to detected host values)

@mlin mlin force-pushed the master branch 2 times, most recently from 7f0d0c0 to 188ab30 Compare November 10, 2019 22:03
@mlin mlin merged commit a71db84 into master Nov 10, 2019
@mlin mlin deleted the mlin-runtime-memory branch November 21, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants