Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add invoking user's group to docker containers #286

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 19, 2019

If a docker image has been baked with a USER directive to drop privileges to some arbitrary uid (a good security practice), then it may have trouble accessing the mounted working directory, which is owned by the user who invoked miniwdl. To support this we

  1. add the invoking user's group to the container (a feature of Docker)
  2. ensure everything miniwdl provisions in the working directory has group read/write permission

Incidentally add a gs:// downloader and a test script mirroring the "Getting Started" tutorial, adding which provoked the permissions change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1323

  • 84 of 86 (97.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 96.866%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/_util.py 29 31 93.55%
Totals Coverage Status
Change from base Build 1315: -0.01%
Covered Lines: 4698
Relevant Lines: 4850

💛 - Coveralls

@mlin mlin merged commit 914add0 into v0.6.x Nov 20, 2019
@mlin mlin deleted the mlin-docker-group branch November 21, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants