Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle docker state corner case triggered by workers going down #375

Merged
merged 6 commits into from
Apr 14, 2020

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Apr 14, 2020

Stress-testing revealed that a task whose assigned worker goes down can end up in one of three distinct modes:

  1. state = running, exit code = -1
  2. state = shutdown, orphaned, or remove
  3. "desired state" = shutdown, orphaned, or remove (with non-terminal state)

The first case is common, while the last two are rare & appear only in stress-testing with artificially-induced worker shutdown 馃槩

@coveralls
Copy link

coveralls commented Apr 14, 2020

Pull Request Test Coverage Report for Build 1770

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.722%

Totals Coverage Status
Change from base Build 1756: 0.04%
Covered Lines: 5489
Relevant Lines: 5675

馃挍 - Coveralls

@mlin mlin merged commit 6b48f5a into master Apr 14, 2020
@mlin mlin deleted the mlin-harden-docker-states branch April 14, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants