Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flake8 linter #407

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Enable flake8 linter #407

merged 5 commits into from
Jul 10, 2020

Conversation

kislyuk
Copy link
Contributor

@kislyuk kislyuk commented Jul 7, 2020 •
edited

Motivation

Enable flake8 linter

  • Add appropriate test(s) to the automatic suite
  • Use make pretty to reformat the code with black
  • Use make check to statically check the code using Pyre and Pylint
  • Send PR from a dedicated branch without unrelated edits
  • Ensure compatibility with this project's MIT license

@kislyuk kislyuk changed the title Akislyuk lint Enable flake8 linter Jul 7, 2020
@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited

Pull Request Test Coverage Report for Build 1999

  • 23 of 23 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 96.686%
Totals Coverage Status
Change from base Build 1997: 0.001%
Covered Lines: 5864
Relevant Lines: 6065
💛 - Coveralls

@kislyuk kislyuk requested a review from mlin July 9, 2020 16:43
@mlin mlin merged commit 497330c into main Jul 10, 2020
@kislyuk kislyuk deleted the akislyuk-lint branch July 11, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlin mlin Awaiting requested review from mlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kislyuk @coveralls @mlin