Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardReference linter #45

Merged
merged 3 commits into from
Nov 26, 2018
Merged

ForwardReference linter #45

merged 3 commits into from
Nov 26, 2018

Conversation

mlin
Copy link
Collaborator

@mlin mlin commented Nov 26, 2018

Links each Expr.Ident to the Decl or Call it references, which is added during document typechecking by threading it through the type environment (as 'context').

This link makes it easy to ask whether the Expr.Ident lexically precedes the Decl/Call. It will also facilitate detection of cyclic dependencies and unused declarations.

Includes a scheme to link each Expr.Ident to the Decl or Call it references, which is added during document typechecking by threading it through the type environment. This will also facilitate cycle detection.
@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 198

  • 30 of 31 (96.77%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 94.088%

Changes Missing Coverage Covered Lines Changed/Added Lines %
WDL/Lint.py 8 9 88.89%
Totals Coverage Status
Change from base Build 191: 0.009%
Covered Lines: 1846
Relevant Lines: 1962

💛 - Coveralls

@mlin mlin merged commit 8a2d74f into master Nov 26, 2018
@mlin mlin deleted the mlin-forward-reference-linter branch February 15, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants